[Fix][Zeta] Fix resource isolation not working on multi node #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 23, 2024 11:52
…hen starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched.
…hen starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched.
…hen starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched.
|
cc @liunaijie as well. |
|
Please add test case. |
|
I check the code with my local env, i miss to submit this part of code, my bad. The current test is only has 1 node, won't have any network transport. so not get exception. |
Hisoka-X
changed the title
|
I have add one test case named: WorkerTagClusterTest |
Hisoka-X
previously approved these changes
Aug 27, 2024
|
Hi @chenqianwen , please retry the failed ci. Thanks. |
Hisoka-X
reviewed
Aug 28, 2024
...se/src/test/java/org/apache/seatunnel/engine/e2e/resourceIsolation/WorkerTagClusterTest.java
Outdated
Show resolved
Hide resolved
…e/src/test/java/org/apache/seatunnel/engine/e2e/resourceIsolation/WorkerTagClusterTest.java
wuchunfu
approved these changes
Aug 28, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Aug 29, 2024
…7471) * [Bug] [resource-isolation tag_filter] separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched. * [Bug] [resource-isolation tag_filter] separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched. * [Bug] [resource-isolation tag_filter] separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched. * [Fix][Zeta] Fix resource isolation not working on multi node test case * [Fix][Zeta] Fix resource isolation not working on multi node test case * [Fix][Zeta] Fix resource isolation not working on multi node test case * [Fix][Zeta] Fix resource isolation not working on multi node test case * Update seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/resourceIsolation/WorkerTagClusterTest.java --------- Co-authored-by: yanggld <yanggld@digiwin.com> Co-authored-by: Jia Fan <fanjiaeminem@qq.com>
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Aug 29, 2024
…7471) * [Bug] [resource-isolation tag_filter] separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched. * [Bug] [resource-isolation tag_filter] separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched. * [Bug] [resource-isolation tag_filter] separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched. * [Fix][Zeta] Fix resource isolation not working on multi node test case * [Fix][Zeta] Fix resource isolation not working on multi node test case * [Fix][Zeta] Fix resource isolation not working on multi node test case * [Fix][Zeta] Fix resource isolation not working on multi node test case * Update seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/resourceIsolation/WorkerTagClusterTest.java --------- Co-authored-by: yanggld <yanggld@digiwin.com> Co-authored-by: Jia Fan <fanjiaeminem@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7469
Purpose of this pull request
separated-cluster-deployment， When starting the worker, specify group=platform, and when submitting the job, specify tag_filter, which is also group=platform, but cannot be matched.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.